Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hash stats information to check hashes between validators #7780

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

sakridge
Copy link
Member

Problem

If state diverges between validators, hard to tell what happened.

Summary of Changes

Add some stats to hash computation.

Fixes #

@sakridge sakridge requested a review from ryoqun January 14, 2020 01:10
@sakridge sakridge force-pushed the hash-stats branch 2 times, most recently from 6df4b0d to 3e39b7d Compare January 14, 2020 01:34
@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #7780 into master will increase coverage by <.1%.
The diff coverage is 96.1%.

@@           Coverage Diff            @@
##           master   #7780     +/-   ##
========================================
+ Coverage    81.9%   81.9%   +<.1%     
========================================
  Files         238     241      +3     
  Lines       51043   51133     +90     
========================================
+ Hits        41821   41905     +84     
- Misses       9222    9228      +6

ryoqun
ryoqun previously approved these changes Jan 14, 2020
Copy link
Member

@ryoqun ryoqun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits.

This is really good thing to have! Surely, this will be helpful once we can repro #7736, and find something with this!

runtime/src/accounts_db.rs Outdated Show resolved Hide resolved
runtime/src/accounts_db.rs Show resolved Hide resolved
runtime/src/accounts_db.rs Show resolved Hide resolved
runtime/src/accounts_db.rs Outdated Show resolved Hide resolved
runtime/src/bank.rs Show resolved Hide resolved
@mergify mergify bot dismissed ryoqun’s stale review January 14, 2020 19:07

Pull request has been modified.

@sakridge sakridge added automerge Merge this Pull Request automatically once CI passes v0.22 labels Jan 14, 2020
@solana-grimes solana-grimes merged commit 3b78be8 into solana-labs:master Jan 14, 2020
mergify bot pushed a commit that referenced this pull request Jan 14, 2020
automerge

(cherry picked from commit 3b78be8)

# Conflicts:
#	runtime/src/accounts.rs
#	runtime/src/accounts_db.rs
sakridge added a commit to sakridge/solana that referenced this pull request Jan 14, 2020
sakridge added a commit to sakridge/solana that referenced this pull request Jan 14, 2020
This was referenced May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants