-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hash stats information to check hashes between validators #7780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
force-pushed
the
hash-stats
branch
2 times, most recently
from
January 14, 2020 01:34
6df4b0d
to
3e39b7d
Compare
Codecov Report
@@ Coverage Diff @@
## master #7780 +/- ##
========================================
+ Coverage 81.9% 81.9% +<.1%
========================================
Files 238 241 +3
Lines 51043 51133 +90
========================================
+ Hits 41821 41905 +84
- Misses 9222 9228 +6 |
ryoqun
previously approved these changes
Jan 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits.
This is really good thing to have! Surely, this will be helpful once we can repro #7736, and find something with this!
sakridge
added
automerge
Merge this Pull Request automatically once CI passes
v0.22
labels
Jan 14, 2020
mergify bot
pushed a commit
that referenced
this pull request
Jan 14, 2020
automerge (cherry picked from commit 3b78be8) # Conflicts: # runtime/src/accounts.rs # runtime/src/accounts_db.rs
sakridge
added a commit
to sakridge/solana
that referenced
this pull request
Jan 14, 2020
sakridge
added a commit
to sakridge/solana
that referenced
this pull request
Jan 14, 2020
mvines
pushed a commit
that referenced
this pull request
Jan 15, 2020
This was referenced Aug 1, 2022
This was referenced Aug 2, 2022
This was referenced Aug 22, 2022
This was referenced Aug 24, 2022
Open
This was referenced May 14, 2024
Open
Open
Open
Open
This was referenced May 22, 2024
This was referenced May 22, 2024
This was referenced Oct 12, 2024
This was referenced Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If state diverges between validators, hard to tell what happened.
Summary of Changes
Add some stats to hash computation.
Fixes #